Skip to content

Ga security policy v2 #16094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roaks3 merged 2 commits into from
Jan 14, 2026
Merged

Ga security policy v2 #16094

roaks3 merged 2 commits into from
Jan 14, 2026
+2 −20

Conversation

@SCSAndre
Copy link
Contributor

@SCSAndre SCSAndre commented Jan 7, 2026 •
edited by roaks3
Loading

Description

This PR promotes the request_body_inspection_size field from Beta to GA in the google_compute_security_policy resource.

GA API Confirmation: The Compute v1 (GA) API already exposes requestBodyInspectionSize and supports values up to 64KB.

Changes Made

1. Schema Definition

  • Removed version guards ({{- if ne $.TargetVersionName "ga" }}) from request_body_inspection_size field

2. Expand/Flatten Functions

  • Removed version guards from expandSecurityPolicyAdvancedOptionsConfig
  • Removed version guards from flattenSecurityPolicyAdvancedOptionsConfig

3. ForceSendFields

  • Updated to include advancedOptionsConfig.requestBodyInspectionSize for all versions

4. Documentation

  • Removed [Beta] marker from request_body_inspection_size field

5. Tests

  • Removed version guards from test steps for request_body_inspection_size
  • Tests now run for both GA and Beta providers

Testing

The acceptance test TestAccComputeSecurityPolicy_withAdvancedOptionsConfig includes:

  • Test step with request_body_inspection_size = "64KB"
  • Import verification
  • Full lifecycle validation
compute: promoted `request_body_inspection_size` to GA in `google_compute_security_policy` resource (ga)

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 7, 2026
@github-actions github-actions bot requested a review from roaks3 January 7, 2026 21:32
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@SCSAndre
feat(compute): Promote request_body_inspection_size to GA in google_c…
74aca0d 
…ompute_security_policy

This change promotes the request_body_inspection_size field from Beta to GA
in the google_compute_security_policy resource.

The GA Compute API (v1) now supports this field with values: 8KB, 16KB, 32KB,
48KB, and 64KB for WAF request body inspection configuration.

Changes:
- Removed version guards from schema definition
- Removed version guards from expand/flatten functions
- Updated ForceSendFields to include field for all versions
- Removed [Beta] marker from documentation
- Enabled tests for GA provider

```release-note:enhancement
compute: promoted `request_body_inspection_size` to GA in `google_compute_security_policy`
```
@SCSAndre SCSAndre force-pushed the ga-security-policy-v2 branch from 4bf5ecb to 74aca0d Compare January 7, 2026 22:10
@maxi-cit
Copy link
Contributor

maxi-cit commented Jan 8, 2026

Hi @roaks3, a client has asked about support related to this PR.
Would you mind running the tests to verify everything is in good shape?
Appreciate it!

@github-actions
Copy link

github-actions bot commented Jan 12, 2026

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@SCSAndre
Copy link
Contributor Author

SCSAndre commented Jan 13, 2026

Hey @roaks3, could you take a look on that, please?

roaks3
roaks3 approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; running tests now, although they will likely be unchanged because we only run beta tests

@modular-magician modular-magician added service/compute-security-policy and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 13, 2026
@modular-magician
Copy link
Collaborator

modular-magician commented Jan 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 48 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 2 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 13, 2026

Tests analytics

Total tests: 1325
Passed tests: 1238
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeSecurityPolicy_withAdvancedOptionsConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 13, 2026

🟢 Tests passed during RECORDING mode:
TestAccComputeSecurityPolicy_withAdvancedOptionsConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 14, 2026
@github-actions github-actions bot requested a review from roaks3 January 14, 2026 15:36
@SCSAndre
Copy link
Contributor Author

SCSAndre commented Jan 14, 2026

@roaks3 could you, please, run the check again?

I forgot to change the meta.yaml file before.

Probably will pass now and can be merged.

Tks!

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 14, 2026
@modular-magician
Copy link
Collaborator

modular-magician commented Jan 14, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 50 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 4 files changed, 3 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 14, 2026

Tests analytics

Total tests: 1325
Passed tests: 1239
Skipped tests: 86
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@SCSAndre
Copy link
Contributor Author

SCSAndre commented Jan 14, 2026

@roaks3 tks for your attention Ryan!

Could you give me an estimate of when the merger will take place?

@roaks3 roaks3 added this pull request to the merge queue Jan 14, 2026
@SCSAndre
Copy link
Contributor Author

SCSAndre commented Jan 14, 2026

@roaks3 tks a lot!

@github-actions github-actions bot requested a review from roaks3 January 14, 2026 17:52
Merged via the queue into GoogleCloudPlatform:main with commit ea30169 Jan 14, 2026
29 checks passed
This was referenced Jan 14, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roaks3 roaks3 Awaiting requested review from roaks3

Assignees

No one assigned

Labels

service/compute-security-policy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SCSAndre @maxi-cit @modular-magician @roaks3